Use MSVC toolchain when building FFmpeg on Windows #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
scotts
reviewed
Aug 12, 2025
| @@ -20,6 +20,10 @@ | |||
| set -eux | |||
|
|
|||
| prefix="${FFMPEG_ROOT}" | |||
| args="" | |||
| if [[ "$OSTYPE" == "msys" ]]; then | |||
There was a problem hiding this comment.
Further down, we use $(uname) to determine we're running on Mac (Darwin). Can we use the same mechanism here, or if we can't, can we change the mechanism further down? I think using one mechanism to determine platform will make this script easier to understand and maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done in torchaudio: https://github.com/pytorch/audio/blob/6fbc710b617f79b992ef2ebc7f95e818aa390293/.github/scripts/ffmpeg/build.sh#L20-L22